Skip to content

String literals should not be duplicated #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

String literals should not be duplicated #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions app/src/main/java/com/malin/rengwuxianrxjava/activity/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,15 @@
* 备注:
*/
public class MainActivity extends Activity {
public static final String HELLO = "Hello";
private static final String TAG = "MainActivity";
private static final String TAG_FOR_LOGGER = "MainActivity_I_LOVE_RXJAVA";
private static final String ERROR = "故意让程序出错";
private static final String JPG = ".jpg";
public static final String WORLD = "World";
public static final String 观察者_OBSERVER_ON_COMPLETED = "观察者-observer:onCompleted()";
public static final String 观察者_OBSERVER_ON_NEXT = "观察者-observer:onNext():";
public static final String RETROFIT = "retrofit";
private int mCounter;//循环的计数器
private AvoidRecoveredAppearErrorImageView mImageView;
private Bitmap mManyBitmapSuperposition = null;
Expand Down Expand Up @@ -403,8 +408,8 @@ private void method0() {
Observable<String> observable = Observable.create(new Observable.OnSubscribe<String>() {
@Override
public void call(Subscriber<? super String> subscriber) {
subscriber.onNext("Hello");
subscriber.onNext("World");
subscriber.onNext(HELLO);
subscriber.onNext(WORLD);
subscriber.onNext("!");
subscriber.onCompleted();
subscriber.onError(new Throwable());
Expand All @@ -423,7 +428,7 @@ public void call(Subscriber<? super String> subscriber) {
Observer<String> observer = new Observer<String>() {
@Override
public void onCompleted() {
Logger.d("观察者-observer:onCompleted()");
Logger.d(观察者_OBSERVER_ON_COMPLETED);
}

@Override
Expand All @@ -433,7 +438,7 @@ public void onError(Throwable e) {

@Override
public void onNext(String s) {
Logger.d("观察者-observer:onNext():" + s);
Logger.d(观察者_OBSERVER_ON_NEXT + s);
// getException();//故意让程序出现异常,用于测试onError()方法的执行....
}
};
Expand Down Expand Up @@ -465,7 +470,7 @@ private void method1() {

//1:被观察者:
//just(T...): 将传入的参数依次发送出来
Observable<String> observable = Observable.just("Hello", "World", "!");
Observable<String> observable = Observable.just(HELLO, WORLD, "!");
// 将会依次调用：
// onNext("Hello");
// onNext("World");
Expand All @@ -477,7 +482,7 @@ private void method1() {
Observer<String> observer = new Observer<String>() {
@Override
public void onCompleted() {
Logger.d("观察者-observer:onCompleted()");
Logger.d(观察者_OBSERVER_ON_COMPLETED);
}

@Override
Expand All @@ -487,7 +492,7 @@ public void onError(Throwable e) {

@Override
public void onNext(String s) {
Logger.d("观察者-observer:onNext():" + s);
Logger.d(观察者_OBSERVER_ON_NEXT + s);
// getException();//故意让程序出现异常,用于测试onError()方法的执行....
}
};
Expand All @@ -511,7 +516,7 @@ private void method2() {
//3:订阅-被观察者被观察者订阅


String[] array = new String[]{"Hello", "World", "!"};
String[] array = new String[]{HELLO, WORLD, "!"};
//1:被观察者:
//just(String[] array) 将传入的数组或 Iterable 拆分成具体对象后，依次发送出来。
Observable observable = Observable.from(array);
Expand All @@ -526,7 +531,7 @@ private void method2() {
Observer observer = new Observer() {
@Override
public void onCompleted() {
Logger.d("观察者-observer:onCompleted()");
Logger.d(观察者_OBSERVER_ON_COMPLETED);
}

@Override
Expand All @@ -537,7 +542,7 @@ public void onError(Throwable e) {
@Override
public void onNext(Object o) {
String str = (String) o;
Logger.d("观察者-observer:onNext():" + str);
Logger.d(观察者_OBSERVER_ON_NEXT + str);
// getException();//故意让程序出现异常,用于测试onError()方法的执行....
}
};
Expand All @@ -557,7 +562,7 @@ public void onNext(Object o) {
*/
private void method3() {

String[] array = new String[]{"Hello", "World", "!"};
String[] array = new String[]{HELLO, WORLD, "!"};
//1:被观察者
Observable observable = Observable.from(array);

Expand Down Expand Up @@ -585,7 +590,7 @@ public void call(Object o) {
private void method4() {

//1:被观察者
Observable observable = Observable.from(new String[]{"Hello", "World", "!"});
Observable observable = Observable.from(new String[]{HELLO, WORLD, "!"});

//2:观察者
Action1 onNextAction = new Action1() {
Expand Down Expand Up @@ -619,7 +624,7 @@ public void call(Throwable throwable) {
*/
private void method5() {
//1:被观察者
Observable observable = Observable.from(new String[]{"Hello", "World", "!"});
Observable observable = Observable.from(new String[]{HELLO, WORLD, "!"});


//2:观察者
Expand Down Expand Up @@ -1254,7 +1259,7 @@ private void method23() {
mAdapter = new ArrayAdapter<String>(MainActivity.this, R.layout.item_log, R.id.item_log, new ArrayList<String>());
mResultListView.setAdapter(mAdapter);

mSubscription.add(mGitHubApi.getContributorsObservable("square", "retrofit")
mSubscription.add(mGitHubApi.getContributorsObservable("square", RETROFIT)
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.doOnSubscribe(new Action0() {
Expand Down Expand Up @@ -1286,12 +1291,12 @@ public void onNext(List<Contributor> contributors) {
mAdapter.add(String.format("%s has made %d contributions to %s",
c.login,
c.contributions,
"retrofit"));
RETROFIT));

Logger.d(String.format("%s has made %d contributions to %s",
c.login,
c.contributions,
"retrofit"));
RETROFIT));
}
}
}));
Expand Down