Skip to content

Fix keyword arguments passed as **kwargs #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix keyword arguments passed as **kwargs #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40dc612
Fix **kwargs in function call
goldvitaly Aug 22, 2019
cf0e7ab
Merge pull request #1 from goldvitaly/patch-2
goldvitaly Aug 22, 2019
56409e0
Add function call test
goldvitaly Aug 22, 2019
17f4116
Merge pull request #2 from goldvitaly/patch-3
goldvitaly Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion codegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,10 @@ def write_comma():
self.visit(arg)
for keyword in node.keywords:
write_comma()
self.write(keyword.arg + '=')
if keyword.arg is not None:
self.write(keyword.arg + '=')
else:
self.write('**')
self.visit(keyword.value)
if node.starargs is not None:
write_comma()
Expand Down
6 changes: 5 additions & 1 deletion test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ def test_import(self):
self.assertPreserved("import intertools as iterators")
self.assertPreserved("from math import floor as fl, ceil as cl")


def test_function_call(self):
self.assertPreserved("f(x, 5, x=7)")
self.assertPreserved("f(x, **{'x': 7})")
self.assertPreserved("f(x, *['x'])")

if __name__ == '__main__':
unittest.main()