Open
Conversation
|
Let's fix those errors and get this merged, yeah? I'm using this fork for now. |
hkmoon
reviewed
Feb 20, 2020
| export const svg = function(d3) { | ||
| return { | ||
| arrow: require('./arrow')(require('../util')().functor) | ||
| arrow: _arrow(util().functor)() |
There was a problem hiding this comment.
There is a bug of calling arrow. It passes as a function by removing ().
arrow: _arrow(util().functor)() should be arrow: _arrow(util().functor)
|
The gist of using esModule based techan.js in jupyter notebook is https://gist.github.com/hkmoon/baa4926c5650638cbec7fe5d6693103a |
Open
gruppler
added a commit
to gruppler/techan.js
that referenced
this pull request
Feb 8, 2026
Bug fix from PR andredumas#220 review comments by hkmoon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the integration with my ES6 projects. not sure if you want to merge my work anyhow I'm happy to share ;)