Add Custom Collection Name Option & Refactor Authentication Logic #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh dang, awesome PR, thank you @Thiago-Rizzo! I'll try and get round to testing this as soon as I can! |
|
@Thiago-Rizzo looks like we may have a test failing due to this? Would you mind adding a test to cover the new change too please? 🙏 |
tomirons
requested changes
Feb 18, 2025
| config()->set('api-postman.authentication', [ | ||
| 'method' => $this->option('bearer') ? 'bearer' : ($this->option('basic') ? 'basic' : null), | ||
| 'token' => $this->option('bearer') ?? $this->option('basic') ?? null, | ||
| $this->resolveAuth(); |
There was a problem hiding this comment.
I'm not a big fan of breaking this out. I would like to keep it fluent.
$exporter
->to($filename)
->collectionName($collectionName)
->setAuthentication($this->resolveAuth())
->export();
What gets returned from resolveAuth is the instance of the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two key improvements:
Custom Collection Name
Added an option to specify a custom collection name (collection_name) instead of using the filename by default.
Authentication Logic Refactor
Separated authentication logic from the main code to improve maintainability and readability.