Skip to content

Reverse loop over messages to find quoted message. Improves performance as quoted messages will be near the current message (end of the messages iterator). #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nielsderdaele wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reverse loop over messages to find quoted message. Improves performance as quoted messages will be near the current message (end of the messages iterator). #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d338770
Reverse loop over messages to find quoted message. findByMessageId =>…
nielsderdaele Apr 16, 2022
2a81cd2
cleanup whitespace
nielsderdaele Apr 16, 2022
f8d4714
fix whitespace
nielsderdaele Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/WhatsApp/QueryMessagesThread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ void QueryMessagesThread::interrupt()
sqlite3_interrupt(sqLiteDatabase.getHandle());
}

WhatsappMessage *QueryMessagesThread::findByMessageId(const std::string &messageId)
WhatsappMessage *QueryMessagesThread::findByMessageIdReverse(const std::string &messageId)
{
for(std::vector<WhatsappMessage *>::iterator it = messages.begin(); it != messages.end(); ++it)
for(std::vector<WhatsappMessage *>::reverse_iterator it = messages.rbegin(); it != messages.rend(); ++it)
{
WhatsappMessage *message = *it;
if (message->getMessageId() == messageId)
Expand Down Expand Up @@ -92,7 +92,7 @@ void QueryMessagesThread::run()
WhatsappMessage *quotedMessage = NULL;
if (quotedMessageId.length() > 0)
{
quotedMessage = findByMessageId(quotedMessageId);
quotedMessage = findByMessageIdReverse(quotedMessageId);
}
WhatsappMessage *message = new WhatsappMessage(messageId, chatId, fromMe == 1, status, data, timestamp, 0, 0, mediaUrl, mediaMimeType, mediaWhatsappType, mediaSize, mediaName, mediaCaption, mediaDuration, latitude, longitude, thumbImage, thumbImageSize, remoteResource, rawData, rawDataSize, thumbnailData, thumbnailDataSize, quotedMessage, linkId > 0);
messages.push_back(message);
Expand Down
2 changes: 1 addition & 1 deletion source/WhatsApp/QueryMessagesThread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class QueryMessagesThread : public ThreadWindows
const std::string &chatId;
std::vector<WhatsappMessage *> &messages;

WhatsappMessage *findByMessageId(const std::string &messageId);
WhatsappMessage *findByMessageIdReverse(const std::string &messageId);

public:
QueryMessagesThread(WhatsappDatabase &database, SQLiteDatabase &sqLiteDatabase, const std::string &chatId, std::vector<WhatsappMessage *> &messages);
Expand Down