Fixes invalid ‘sed’ syntax on macOS [closes issue 378] #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syntax error has been reported going back to 2017, but it appears all of the proposed fixes were closed before @andreafabrizi was able to merge them.
My fix should only change the behavior on macOS systems but it should leave the existing
sedcommand for all other OSes since I am not sure if the same syntax would work on all of them.For Reference, see the following:
#378
#481
#510
#404
Note
My text editor also seems to have removed some superfluous whitespace. Sorry for that. This is my first pull request, so if I'm missed a step or anything, please let me know.