Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filenames with percent signs #487

Merged
merged 2 commits into from
Nov 22, 2020
Merged

Fix filenames with percent signs #487

merged 2 commits into from
Nov 22, 2020

Conversation

JonathanLennox
Copy link
Contributor

Fixes issue #486.

@JonathanLennox
Don't pass literal filenames as the 'printf' format string.
4ccc5c1 
Otherwise it gets confused by printf format specifications and escapes (% and \) in the filename.
@JonathanLennox
Add unit test for file names containing percent signs.
6ffe543
@andreafabrizi andreafabrizi merged commit a36724d into andreafabrizi:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ubiquitine Ubiquitine Ubiquitine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonathanLennox @Ubiquitine @andreafabrizi