Fix bad usage of bitwise OR in index.js #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the intention was to use "||" and not "|"
|
This totally fix my problem (I had traced it to the same bug). |
|
Have you tried using This is a simple and old fork of it, this fork is not needed anymore since the original repo implemented the same functionality. If this is not the case I could merge and release this for you. |
|
I had some trouble getting the latest version of https://github.com/guzart/gulp-ng-constant to work with my somewhat legacy project, but this indeed fixed the problem. |
|
Please merge this request. We need it in a legacy project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the intention was to use "||" and not "|"