feat(MONIT-87):"Agregar advertencia en edicion de elementos rup"#77
Open
nicolasarana wants to merge 2 commits intomasterfrom
Open
feat(MONIT-87):"Agregar advertencia en edicion de elementos rup"#77nicolasarana wants to merge 2 commits intomasterfrom
nicolasarana wants to merge 2 commits intomasterfrom
Conversation
nicolasarana
force-pushed
the
MONIT-87
branch
3 times, most recently
from
16ee2d9 to
afbc90f
Compare
nicolasarana
force-pushed
the
MONIT-87
branch
from
afbc90f to
5873ddc
Compare
Contributor
|
Nico, como lo vimos recien te dejo videito de un caso... MON-87.mp4 |
MarianoCampetella
requested changes
Sep 22, 2025
| const nombresRuper = rupersDuplicados.map(e => `<b>${e.nombre}</b>`).join('; ') || 'desconocido'; | ||
|
|
||
| this.plex.confirm( | ||
| `⚠️ El concepto "${conceptoDuplicado.fsn}" ya existe en los Ruper: ${nombresRuper}.<br>¿Deseás igualmente agregarlo aquí?`, |
Contributor
There was a problem hiding this comment.
Sacarle el acento a deseas.
Contributor
Author
There was a problem hiding this comment.
ya fue corregido
| return; | ||
| } | ||
| // Guardá la molécula completa (incluye todos los requeridos y sus params actualizados) | ||
| this.guardarMolecula(); |
Contributor
There was a problem hiding this comment.
Esta función se podría meter dentro de un else para evitar un posible segundo llamado ya que si en primer lugar se ejecutara la de la línea 174 luego se ejecutaría la de la linea 181.
Contributor
|
Nico, como vimos hace un momento, no se veeria el error en la consola. Lo unico a mencionar es cuando se muestra el modal... 
si esta bien la vista de toooodos los conceptos que estarian involucrados. |
nicolasarana
force-pushed
the
MONIT-87
branch
from
5873ddc to
2ea8d73
Compare
nicolasarana
added
changes done
nicolasarana
force-pushed
the
MONIT-87
branch
from
2ea8d73 to
092cc8f
Compare
Contributor
|
Faltaría solamente eliminar el icono de alerta nomas una vez que se imprime el modal. |
MarianoCampetella
added
changes requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requerimiento
MONIT-87
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion