FEAT: Se agrego una nueva router para hacer patch a las queries.#232
Open
nicolasarana wants to merge 2 commits intomasterfrom
Open
FEAT: Se agrego una nueva router para hacer patch a las queries.#232nicolasarana wants to merge 2 commits intomasterfrom
nicolasarana wants to merge 2 commits intomasterfrom
Conversation
9 tasks
MarianoCampetella
requested changes
Jun 3, 2025
Comment on lines
-169
to
-174
| router.post('/queries/:id/delete', async (req, res, next) => { | ||
| const Query = mongoose.model('queries'); | ||
| const queries: any = await Query.findOne({ nombre: req.params.id }); | ||
| const params = req.body.params; | ||
| const mapping = req.body.mapping || []; | ||
| const fields = req.body.fields; |
Contributor
There was a problem hiding this comment.
Según lo charlado esta ruta se eliminó por error. Volver a agregarla.
MarianoCampetella
requested changes
Aug 13, 2025
bi-queries/index.ts
Outdated
| }); | ||
|
|
||
| router.patch('/queries/:id', async (req, res, next) => { | ||
| console.log(req.body); |
Contributor
There was a problem hiding this comment.
Eliminar console.log(...)
bi-queries/index.ts
Outdated
|
|
||
| return res.json(query); | ||
| } catch (e) { | ||
| console.error(e); |
Contributor
There was a problem hiding this comment.
Eliminar console.log(...)
Author
There was a problem hiding this comment.
Se elimino los console logs
MarianoCampetella
approved these changes
Jan 27, 2026
Contributor
MarianoCampetella
left a comment
There was a problem hiding this comment.
Probado desde postman y funciona correctamente.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/MONIT-67
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API