Repository navigation
Conversation
The tox commands call `uv sync` and `uv run`, which ignore the VIRTUAL_ENV that tox activates and use the project's .venv instead. Every tox env (py313, py314) therefore ran the unit tests on whichever interpreter built .venv (3.13 in CI), so 3.14 was never actually tested. Point UV_PROJECT_ENVIRONMENT at the tox env dir so uv installs into and runs from the env tox created for that interpreter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thierry Moisan <thierry.moisan@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tox commands call
uv syncanduv run, which ignore the VIRTUAL_ENV that tox activates and use the project's .venv instead. Every tox env (py313, py314) therefore ran the unit tests on whichever interpreter built .venv (3.13 in CI), so 3.14 was never actually tested.Point UV_PROJECT_ENVIRONMENT at the tox env dir so uv installs into and runs from the env tox created for that interpreter.
Evidence from CI
From the
Test (py314)job on the latestmainrun (run 38946725826):The job is labelled py314, but the tests run on 3.13.16 from
.venv.With this change, running
tox -e py313andtox -e py314locally reports 3.13.16 from.tox/py313and 3.14.8 from.tox/py314, and the unit tests pass in both.