Native Image SBOM: support extracting symbols in .dynsym section #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ELF files Signed-off-by: Joel Rudsberg <[email protected]>
rudsberg
force-pushed
the
main
branch
2 times, most recently
from
c5128b8 to
cdc3db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for extracting SBOMs embedded in native images where the SBOM symbols are saved in the
.dynsymsection of ELF files. Newer versions of GraalVM Native Image saves the SBOM symbols in the.dynsymsection while older versions saves them in the.symtabsection. This PR ensures SBOM extraction works in both cases.Type of change
Checklist:
*No additional tests were added. The new
getSymbolsfunction is exercised via TestParseNativeImage that calls fetchPkgs. This is a negative test testing that an error is thrown when SBOM extraction is attempted on a native image that wasn't created with an embedded SBOM.