Comparerunsviewspecs#4
Open
sk176h wants to merge 9 commits into
Open
Conversation
so that the same module can be used for compare runs view specs
on the compare runs page
added 1st test case for compare runs view specs 2nd test case partially complete
1. added view specs for compare runs 2. fixed table display logic in getCompareJson.html.erb 3. added exclude filter to spechelper
Extracted compare runs custom matchers into a separate helper file to avoid code duplication in model specs and view specs for compare runs --Shrikant
renamed spec/views/compare_runs/index.html.erb_spec.rb to spec/views/compare_runs/getcomparejson_spec.rb to better reflect the functionality --Shrikant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Aasawaree , this pull request contains view specs for compare runs.
please have a look and let me know if there are any questions
(this also contains the fix for the compare runs view display which you also have fixed at your end ... you probably want to exclude that)
thanks,
Shrikant