Skip to content

fix(web): clear optimistic action properly when deleting event #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ccmdi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(web): clear optimistic action properly when deleting event #410

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
238362a
fix(web): clear optimistic action properly when deleting event
ccmdi Nov 2, 2025
f395501
fix(web): undo change removeOptimisticAction
JeanMeijer Nov 5, 2025
9082617
fix(web): resolve optimistic action cleanup
ccmdi Nov 5, 2025
82ec3f6
fix(web): add missing optimistic id for draft events
ccmdi Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions apps/web/src/components/calendar/flows/delete-event/delete-queue-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ export function DeleteQueueProvider({ children }: DeleteQueueProviderProps) {
const prevEvent = await getEventById(item.event.id);

if (!prevEvent) {
if (item.event?.type === "draft") {
removeOptimisticAction(item.optimisticId);
}
// TODO: draft events are not drafts when they get here
removeOptimisticAction(item.optimisticId);

return;
}
Expand All @@ -48,7 +47,7 @@ export function DeleteQueueProvider({ children }: DeleteQueueProviderProps) {
},
{
onSettled: () => {
removeOptimisticAction(item.optimisticId);
removeOptimisticAction(item.event.id);
Comment thread
JeanMeijer marked this conversation as resolved.
Outdated
},
},
);
Expand Down