drivers: platform: ftd2xx : Fix FTD2XX library GPIO driver. #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduSabau1
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
RaduSabau1
force-pushed
the
staging/ftd2xx_gpio_fix
branch
2 times, most recently
from
506fb6f to
c151200
Compare
If another pin from the same port is being used, the pins direction won't be remembered, therefore fix this issue by having a global variable for it. Also add global variable for values, since it encounters the same problem, especially when setting a new value for another pin, which can break the other pin values. Fix : 5a9583a ("drivers: platform: ftd2xx : Add GPIO support for FTD2XX platform:) Signed-off-by: Radu Sabau <[email protected]>
RaduSabau1
force-pushed
the
staging/ftd2xx_gpio_fix
branch
from
c151200 to
8f1dc11
Compare
buha
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
If another pin from the same port is being used, the pins direction won't be remembered, therefore fix this issue by having a global variable for it.
Also add global variable for values, since it encounters the same problem, especially when setting a new value for another pin, which can break the other pin values.
Fix : 5a9583a ("drivers: platform: ftd2xx : Add GPIO support for FTD2XX platform:)
PR Type
PR Checklist