drivers/potentiometer : Driver for AD5161 #2597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gprasadbng
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
amiclaus
reviewed
May 13, 2025
There was a problem hiding this comment.
please comply with the Submission Checklist as stated in the PR description.
gprasadbng
changed the title
gprasadbng
force-pushed
the
Driver_for_AD5161
branch
from
686f3c0 to
5612632
Compare
buha
reviewed
May 23, 2025
|
|
||
| /******************************************************************************/ | ||
| /*************************** Types Declarations *******************************/ | ||
| /******************************************************************************/ |
buha
reviewed
May 23, 2025
| }; | ||
|
|
||
|
|
||
|
|
buha
reviewed
May 23, 2025
|
|
||
| struct no_os_spi_desc *spi_desc; | ||
| /* Digital interface select GPIO descriptor */ | ||
| struct no_os_gpio_desc *dis_gpio_desc; |
There was a problem hiding this comment.
be consistent in documenting these, some have a comment, some dont, also use /** comment */ syntax, to make it a doxygen comment
gprasadbng
force-pushed
the
Driver_for_AD5161
branch
2 times, most recently
from
b8118d5 to
15e3ee0
Compare
Signed-off-by: gprasad <[email protected]> Driver for potentiometer AD5161/AD5160. These devices uses the I2C interface for programming.
gprasadbng
force-pushed
the
Driver_for_AD5161
branch
from
15e3ee0 to
4f1286c
Compare
buha
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is the driver for the AD5161 digipot.
PR Type
PR Checklist