feat(CMSIS): CFSIO-4121 Call PeripheralInit #1360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a weakly defined function `PeripheralInit` for each SoC which is called in `SystemInit` after `Board_Init` to initialize the peripherals. This function is particular useful for tools which can generate the `PeripheralInit` function based on a user's configuration in a tool. The call to `PeripheralInit` is intentionally after `Board_Init` so that the user defined peripheral initialization is not overwritten.
github-actions
bot
added
MAX32520
|
We're going to need the same thing in the RISC-V variants of SystemInit - e.g. ./Libraries/CMSIS/Device/Maxim/MAX32690/Source/system_riscv_max32690.c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation behind this PR is tool allow configuration tools to generate a
PeripheralInitfunction which will automatically be called beforemainso that the user does not have to call it directly in their application.This PR adds a weakly defined function
PeripheralInitfor each SoC which is called inSystemInitafterBoard_Initto initialize the peripheralsThe call to
PeripheralInitis intentionally afterBoard_Initso that the user defined peripheral initialization is not overwritten. I would also question whether or notPinInitshould be called afterBoard_Initalso ?Checklist Before Requesting Review