Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removing iiod interpreter calls #1249

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dNechita
Copy link
Contributor

'readfd_io' and 'writefd_io' are used when building with cmake flag WITH_AIO=OFF. They are used here:

libiio/iiod/interpreter.c

Lines 165 to 166 in 73bba25

pdata.readfd = readfd_io;
pdata.writefd = writefd_io;

This reverts commit a80a312.

PR Description

  • Please replace this comment with a summary of your changes, and add any context
    necessary to understand them. List any dependencies required for this change.
  • To check the checkboxes below, insert a 'x' between square brackets (without
    any space), or simply check them after publishing the PR.
  • If you changes include a breaking change, please specify dependent PRs in the
    description and try to push all related PRs simultaneously.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked that I did not intoduced new warnings or errors (CI output)
  • I have checked that components that use libiio did not get broken
  • I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

@dNechita
Copy link
Contributor Author

@AlexandraTrifan thank you for finding this issue.

@rgetz
Copy link
Contributor

rgetz commented Feb 21, 2025

This just says there is are missing gaps in CI - we should be building with a variety of build settings to make sure this works. (look at build_readme, and decide which ones should be toggled, and only build on one system).

@dNechita
Copy link
Contributor Author

This just says there is are missing gaps in CI - we should be building with a variety of build settings to make sure this works. (look at build_readme, and decide which ones should be toggled, and only build on one system).

Yes, I was thinking the same thing. I even though automatically generating all cmake flags combinations and do a build for each combination, but not all combination is valid. Deciding a list of combination that make sense should be a good improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants