-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix adrv9361 hold timing violations #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
RetriggerCI |
projects/scripts/route_design.tcl
Outdated
| @@ -0,0 +1,7 @@ | |||
| # This script is used to fix some hold timing issues presented in more recent | |||
| # versions of vivado. This remedy was given by ADM employee through the xilinx | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you meant AMD
LBFFilho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, apart from the comment error @sarpadi pointed out.
This is quite a quirky problem with an equally quirky workaround :)
Let's hope Xilinx fixes the root cause in the next release.
Signed-off-by: Pedro Mendonca <[email protected]>
Signed-off-by: Pedro Mendonca <[email protected]>
Signed-off-by: Pedro Mendonca <[email protected]>
Signed-off-by: Pedro Mendonca <[email protected]>
7e49ce6 to
5f65d98
Compare
|
compiled the project and it seems fine, no timing issues. Maybe adding that it is a quick fix for this version of Vivado in the documentation? I don't think it is reasonable to run twice "route_design" in the future (where I hope AMD fixes this issue lol) |
PR Description
Similar to #1909, this PR addresses timing violations observed following the upgrade to Vivado 2025.1, without requiring any HDL modifications. The solution for this project was to rerun route_design as suggested by AMD Employee on the Xilinx forums.
PR Type
PR Checklist