Skip to content

Conversation

@phlfm
Copy link
Collaborator

@phlfm phlfm commented Dec 1, 2025

⚠️ Warning - these changes have not been tested on the corresponding hardware / setup / boards!

PR Description

Similar to #1909, this PR addresses timing violations observed following the upgrade to Vivado 2025.1, without requiring any HDL modifications. The solution for this project was to rerun route_design as suggested by AMD Employee on the Xilinx forums.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bia1708
Copy link
Collaborator

bia1708 commented Dec 9, 2025

RetriggerCI

@@ -0,0 +1,7 @@
# This script is used to fix some hold timing issues presented in more recent
# versions of vivado. This remedy was given by ADM employee through the xilinx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you meant AMD

Copy link
Contributor

@LBFFilho LBFFilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, apart from the comment error @sarpadi pointed out.

This is quite a quirky problem with an equally quirky workaround :)
Let's hope Xilinx fixes the root cause in the next release.

@phlfm phlfm force-pushed the fix_adrv9361_timing branch from 7e49ce6 to 5f65d98 Compare December 11, 2025 16:57
@caosjr
Copy link
Contributor

caosjr commented Dec 11, 2025

compiled the project and it seems fine, no timing issues. Maybe adding that it is a quick fix for this version of Vivado in the documentation? I don't think it is reasonable to run twice "route_design" in the future (where I hope AMD fixes this issue lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants