ccpackrf_lvds: Remove project #1633
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sarpadi <[email protected]>
Signed-off-by: sarpadi <[email protected]>
sarpadi
requested review from
IuliaCMoldovan,
StancaPop and
LBFFilho
as code owners
StancaPop
requested changes
Mar 31, 2025
| @@ -341,7 +336,7 @@ HDL related | |||
|
|
|||
| - ``*`` only used for ccfmc_lvds (ADRV1CRR-FMC) | |||
| - ``**`` only used for ccbob_cmos (ADRV1CRR-BOB), ccbob_lvds (ADRV1CRR-BOB), ccfmc_lvds (ADRV1CRR-FMC) | |||
| - ``***`` only used for ccfmc_lvds (ADRV1CRR-FMC), ccpackrf_lvds (ADRV1CRR-PACKRF) | |||
| - ``***`` only used for ccfmc_lvds (ADRV1CRR-FMC) | |||
There was a problem hiding this comment.
Delete this line entirely because we already have a case for ADRV1CRR-FMC (* - L337)
There was a problem hiding this comment.
Also delete the IP that was marked with ***
| @@ -202,7 +202,6 @@ command. | |||
| ============= =============================================== | |||
| ccbob_cmos ADRV9361Z7035-SOM (CMOS Mode) + ADRV1CRR-BOB | |||
| ccbob_lvds ADRV9361Z7035-SOM (LVDS Mode) + ADRV1CRR-BOB | |||
| ccpackrf_lvds ADRV9361Z7035-SOM (LVDS Mode) + ADRV1CRR-PACKRF | |||
There was a problem hiding this comment.
Would be better if you put a * or something, and below the table (but inside the collapsible) to have a note saying that this can be found on the last release branch where it was present (and give link)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccpackrf was removed from release after 2021_r2
PR Type
PR Checklist