Skip to content

SPI Engine: fix transfers with echo_sclk #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

SPI Engine: fix transfers with echo_sclk #1595

merged 2 commits into from
Mar 12, 2025

Conversation

LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Feb 28, 2025

PR Description

This PR fixes echo_sclk transfers, which were broken for some cases. Notably, split transfers were problematic, affecting projects like the ad4630. Also fixes another issue where the first transfer would return 0.

tb: analogdevicesinc/testbenches#190

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@LBFFilho
Copy link
Contributor Author

LBFFilho commented Mar 5, 2025

RetriggerCI

@LBFFilho LBFFilho merged commit 3b0fd14 into main Mar 12, 2025
3 of 5 checks passed
@LBFFilho LBFFilho deleted the echo_sclk_fix branch March 12, 2025 12:24
ladace pushed a commit that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants