Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/projects/fmcomms2: add doc for FIR_filter #1587

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

docs/projects/fmcomms2: add doc for FIR_filter #1587

wants to merge 4 commits into from

Conversation

BCapota
Copy link
Collaborator

@BCapota BCapota commented Feb 19, 2025

PR Description

Added the documentation page for fmcomms2 FIR filter example.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@BCapota BCapota added the doc label Feb 19, 2025
@BCapota
docs/projects/fmcomms2: add doc for FIR_filter
9ff08bf 
Signed-off-by: Capota Bianca <[email protected]>
@BCapota
updates
f8cc250 
Signed-off-by: Capota Bianca <[email protected]>
@BCapota
Modify headings
9655e7a 
Signed-off-by: Capota Bianca <[email protected]>
@BCapota
update code and diagrams
b38d4af 
I have updated the code in the TCL console and the diagrams:
fmcomms2_vivado_ref_tx and fmcomms2_vivado_interp_fir_tx.

Signed-off-by: Capota Bianca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan will be requested when the pull request is marked ready for review IuliaCMoldovan is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier will be requested when the pull request is marked ready for review gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop will be requested when the pull request is marked ready for review StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho will be requested when the pull request is marked ready for review LBFFilho is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BCapota @CLAassistant