Fix FIFO error in ADXL372 wrapper code #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the FIFO on the ADXL372 provides 512 records, the adxl_read_reg_multiple() function must support 16-bit values for count, not just 8-bit.
|
Could you please add the Signed-off-by tag, and keep the limit to 75 characters/ line |
| @@ -42,8 +42,7 @@ | |||
| //#define ADXL_DEBUG | |||
|
|
|||
| static int adxl_read_reg_multiple(adxl_spi_handle *spi, unsigned char reg, | |||
| unsigned short count, | |||
| unsigned char *val) | |||
| unsigned count, unsigned char *val) | |||
There was a problem hiding this comment.
this removed the short after the unsigned. I would keep it.
|
Please squash these commits into one and add the Signed-off-by tag. |
amiclaus
reviewed
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the FIFO on the ADXL372 provides 512 records, the adxl_read_reg_multiple() function must support 16-bit values for count, not just 8-bit.