Improve RangeSlider #574
Open
Improve RangeSlider #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use CoerceValue where possible (same as Slider in Avalonia uses) - Add property to control SnapBehavior (not everyone may like it, same as Slider in Avalonia) - SnapToFrequency should be handled in input events, not in PropertyChanged (don't touch Values from the ViewModel sent)
- Do not crash when closing the App due to reset DataContext in CoerceValue - Make sure to follow Snap when pointer down outside the handles
|
Hi @amwx since 2.1.0 seems to be released already, should I switch target branch? |
|
We use the RangeSlider in our project and can't update to Avalonia 11.1.x until this pull request is approved and released. I would be happy to provide any assistance needed toward that end. |
|
@dowdybrown found out that the underlaying issue is solved in latest Avalonia nightly. However FA needs some updates to handle this version so we will need to wait for a fix or build FA on our own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrition of changes
CoerceValuewhere possible (same as Slider in Avalonia uses)IsSnapToStepFrequencyEnabled(not everyone may like it, same as Slider in Avalonia)PropertyChanged(don't touch Values from the ViewModel sent)To test the RangeSlider
I added a minimum sample to SandBox. Can revert this change before merging if you want me to
Tests
Well ... Need to think about useful tests later on, if that PR gets accepted.
Fixed issues
Fixes #568