Repository navigation
AMI upload, the production way - #343
Merged
Merged
Conversation
The importer assembled the `RegisterImage` parameters from the bundle's parameter JSON and a separate `uefi-data` file. Merge the latter into the former at build time, so that the parameter JSON becomes complete (everything except the disk itself). This makes the `[ami][uefi-data]` subtarget redundant, so drop it. Signed-off-by: Martin Pitt <martin@amutable.com>
The importer took the `[ami]` bundle directory and assumed its layout, so it could only import the build in buck-out/. Make it independent of that layout, and let it take the disk and the parameters as two separate path arguments. Signed-off-by: Martin Pitt <martin@amutable.com>
The [ami] bundle linked into buck-out, which was problematic: the RegisterImage JSON could not be published as part of a release, and it tied the *upload* of the AMI (which needs AWS credentials) to the build (which shouldn't have access to these credentials). Replace the bundle with a `<basename>.ami.json` that `[ami]` publishes; that plus the disk is now everything that's necessary to upload an AMI, outside of a built buck tree. Signed-off-by: Martin Pitt <martin@amutable.com>
martinpitt
force-pushed
the
ami-upload
branch
from
October 20, 2026 14:02
08b0731 to
3dd5905
Compare
A release carries the disk as [raw.zst], as the raw is too big to copy around. Stream a .raw.zst disk into the snapshot. Update the docs to show how to import an AMI from the two released files (.raw.zst and .ami.json), as that's how it should happen in production. Signed-off-by: Martin Pitt <martin@amutable.com>
martinpitt
force-pushed
the
ami-upload
branch
from
October 20, 2026 15:09
3dd5905 to
21d0dd8
Compare
daandemeyer
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
bin/tine amialias is convenient for developers, but not suitable for production: we don't want the "build" step to have access to the AWS credentials. Split the AMI metadata build, and do the upload from two explicitly given file paths (disks and registration metadata). See individual commits for details.