Repository navigation
image: Make a VM's aliases as incompatible as the VM - #341
Merged
daandemeyer merged 2 commits intoOct 20, 2026
Merged
Conversation
The pinned buck2 reports a target whose target_compatible_with resolves to select_incompatible() as an error instead of skipping it. A target that can't be built for an architecture then needs a constraint value that no platform sets. The 2026-10-20 release contains the upstream fix, so let's bump to it. Signed-off-by: Daan De Meyer <daan@amutable.com>
martinpitt
reviewed
Oct 20, 2026
image_vm and vm_smoke only boot a disk of the host's architecture, so they require the host's cpu. Their distribution aliases don't. Buck reports a compatible alias over an incompatible VM as an error, so a build of tine//... for another architecture can't skip the aliases. Let's give every distributed rule a target_compatible_with that adds to the distributions it serves and that its aliases take as well. Signed-off-by: Daan De Meyer <daan@amutable.com>
daandemeyer
force-pushed
the
push-rxwpnvzrspwu
branch
from
October 20, 2026 12:47
d4c5b4d to
76a5056
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image_vm and vm_smoke only boot a disk of the host's architecture, so they
require the host's cpu. Their distribution aliases don't. Buck reports a
compatible alias over an incompatible VM as an error, so a build of tine//...
for another architecture can't skip the aliases. Let's give every distributed
rule a target_compatible_with that adds to the distributions it serves and
that its aliases take as well.
Signed-off-by: Daan De Meyer daan@amutable.com