Repository navigation
go: Add build_mode to go.package - #291
Merged
Merged
Conversation
go.package always builds with the toolchain's default build mode. On Linux that is an executable linked at a fixed address. A distribution that hardens its binaries needs them position independent. Add build_mode to select -buildmode=pie, and apply it to the test binaries as well. Signed-off-by: Daan De Meyer <daan@amutable.com>
daandemeyer
force-pushed
the
push-tnounronwqzw
branch
from
October 10, 2026 21:21
7363990 to
225d30e
Compare
Member
Author
|
Only docs added, and the feature is trivial, so gonna merge this quickly so I can make progress on my other stuff that needs this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.package always builds with the toolchain's default build mode. On Linux
that is an executable linked at a fixed address. A distribution that hardens
its binaries needs them position independent. Add build_mode to select
-buildmode=pie, and apply it to the test binaries as well.
Signed-off-by: Daan De Meyer daan@amutable.com