Support bindings on non-AMP elements #895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going with a wrapper based approach for none AMP elements for now: ``` <AmpBind bindText="greeting"> <div /> </AmpBind> ``` I don't see a different way to support the `bindX` shortcut for non-AMP elements.
alankent
reviewed
Jan 10, 2020
| const newProps = {}; | ||
| Object.keys(rest).forEach(key => { | ||
| if (/^bind[A-Z]/g.test(key)) { | ||
| const newKey = `data-amp-bind-${key.substring(4).toLowerCase()}`; |
There was a problem hiding this comment.
Do you want to lower case the whole string or just the first character of the string? I know standard HTML elements won't have hyphenated names, but just felt a little risking assuming nothing else ever will.
There was a problem hiding this comment.
The React toString serializer will automatically lowercase attribute names. So I think it's fine to lowercase by default.
|
|
||
| ``` | ||
| <div data-amp-bind-text="hello"/> | ||
| <button on="tap:AMP.setState({ "hello": "world" })"> | ||
| <AmpBind bindText="greeting"> |
There was a problem hiding this comment.
It is a pity extra markup is required find bind attributes, but if there is no alternative supported by Next.js then a wrapper element names sense.
There was a problem hiding this comment.
I'm not happy about it either. I see two other options:
- HTML Element specific components:
<AmpDiv bindText/>
This would have the added benefit of element specific auto completion. But it's probably more confusing than it helps. - Add
bindXtypes to the HTML elements and rename the attributes in AMP Optimizer. This would work best, but the downside is that it means we have to move Next.js specific features into AMP Optimizer.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going with a wrapper based approach for none AMP elements for now:
I don't see a different way to support the
bindXshortcut for non-AMPelements.