Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cross-platform portable #878

Closed
wants to merge 2 commits into from
Closed

Make cross-platform portable #878

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2019

This pull request addresses two bugs exclusive to Windows:

Details are provided in their respective commit descriptions. Tested on Windows 10 and Debian 9.

4mfie added 2 commits August 6, 2019 21:19
The `highlights` package depends on a version range of the `first-mate` package, which currently resolves to v7.4.0. This version of `first-mate` depends on `oniguruma` v7.2.0. This version of `oniguruma` is broken. I am locking `first-mate` at v7.3.0, which uses the previous functioning version of `oniguruma` (v7.1.0) in order for `npm i` to complete.
The `npm run build` command fails on Windows 10 due to these two problematic lines, which have been updated to use a portable way of doing path segmentation.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ghost
Copy link
Author

ghost commented Aug 7, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@@ -42,6 +42,7 @@
"eslint-plugin-babel": "^4.0.1",
"eslint-plugin-google-camelcase": "0.0.2",
"extract-text-webpack-plugin": "^2.0.0-rc.3",
"first-mate": "7.3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this dependency needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's explained in the commit message. I'll paste its contents below for the sake of convenience.

The highlights package depends on a version range of the first-mate package, which currently resolves to v7.4.0. This version of first-mate depends on oniguruma v7.2.0. This version of oniguruma is broken. I am locking first-mate at v7.3.0, which uses the previous functioning version of oniguruma (v7.1.0) in order for npm i to complete.

@alankent
Copy link
Collaborator

Hi @sebastianbenz - just a ping on whether you want to accept or reject this PR so we can close it out. Thanks!

@sebastianbenz
Copy link
Collaborator

Let's close this for now, as we're going to deprecate the old template build process anyway. The should make sure though that the new version works cross platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants