Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/kotlin/exposure/ExposureService.kt
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ internal fun Exposure.toAmplitudeEvent(): List<Event> {
} else if (variant.value != null) {
put("[Experiment] Variant", variant.value)
}
val experimentKey = variant.metadata?.get("experimentKey") as? String
if (experimentKey != null) {
put("[Experiment] Experiment Key", experimentKey)
}
if (variant.metadata != null) {
put("metadata", JSONObject(variant.metadata.toMap()))
}
Expand Down
21 changes: 19 additions & 2 deletions src/test/kotlin/exposure/ExposureServiceTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,22 @@ class ExposureServiceTest {
"default" to true,
)
),
"with-experiment-key" to Variant(
key = "treatment",
value = "treatment",
metadata = mapOf(
"segmentName" to "All Other Users",
"flagType" to "experiment",
"flagVersion" to 10,
"default" to false,
"experimentKey" to "exp-1",
)
),
"empty-variant" to Variant()
)
val exposure = Exposure(user, results)
val events = exposure.toAmplitudeEvent()
Assert.assertEquals(2, events.size)
Assert.assertEquals(3, events.size)
for (event in events) {
Assert.assertEquals(user.userId, event.userId)
Assert.assertEquals(user.deviceId, event.deviceId)
Expand All @@ -40,6 +51,12 @@ class ExposureServiceTest {
val flagKey = event.eventProperties?.getString("[Experiment] Flag Key")
Assert.assertEquals(results[flagKey]?.key, if (event.eventProperties.has("[Experiment] Variant")) event.eventProperties.getString("[Experiment] Variant") else null)

if (flagKey == "with-experiment-key") {
Assert.assertEquals("exp-1", event.eventProperties.getString("[Experiment] Experiment Key"))
} else {
Assert.assertFalse(event.eventProperties.has("[Experiment] Experiment Key"))
}

val userProperties = event.userProperties
Assert.assertEquals(2, userProperties.length())
if (results[flagKey]?.key != null || results[flagKey]?.value != null) {
Expand All @@ -54,7 +71,7 @@ class ExposureServiceTest {
}
Assert.assertEquals(0, userProperties.getJSONObject("\$unset").length())

val canonicalization = "user device empty-variant null flag-key-1 on flag-key-2 off "
val canonicalization = "user device empty-variant null flag-key-1 on flag-key-2 off with-experiment-key treatment "
val expected = "user device ${("$flagKey $canonicalization").hashCode()} ${exposure.timestamp / DAY_MILLIS}"
Assert.assertEquals(expected, event.insertId)
}
Expand Down
Loading