Added https support #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it might be better if the certificate was generated by the container instead of being hard-coded in the repo. Doing it this way, everyone has the same private key and it isn’t very private. If the certificate is generated as part of spinning up the container then it will keep them unique |
|
I agree, this should be pretty easy to set up on container start. That being said... I seriously think everyone should use something like Traefik which makes generating certs with Letsencrypt super simple. Alternatively making it easier for people to just generate and use their own certs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default image should already support https.
Added port based virtual hosting + self-signed certficates + two new volumes /etc/ssl and /etc/apache2