feat: safe area styling for ios pwa #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll check it out tomorrow. I also have an iPhone but it doesn't do this. Is this a specific model? |
Depends if you have the notch or not, XCode iOS sim has all of them I think I tested with iPhone 15 |
|
I am going to merge this. But I see no difference on my phone and simulator. I am using iPhone 16 and it is below the nudge. 
I think what would be nice is to support the nudge on the left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds required meta tags and some safe area styling for PWA to render correctly on iOS.
I was able to test this by opening iOS Simulator in XCode and going to
http:/localhost:3100in safari, and then pressing share button and saving it to home screen.Before:
After: