-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds pwa in production mode #3691
Conversation
Did a pull but I don't see a |
I only installed the service worker because the URLs can change. I wasn't aware of a manifest.json. Let me see if that's something I can do. |
Ok that was a little more tricky. I added a manifest now. Wait till push is done and try again... Although, I am pretty sure with custom base something would break because the manifest doesn't know about it. |
@stasadance hmmmm it seems like the service worker breaks auth as the assets are cached. Do you need service worker? Can I do JUST manifest? |
Manifest alone is fine. |
Manifest works pretty well on my device. Adding the website to my home screen in iOS safari now results in an app like feel where it opens Dozzle in full screen instead of in the browser. Small thing I noticed.. The site doesn't adjust for the phone's insets in standalone display mode so it looks a bit weird. Screenshot for reference. ![]() I think this can be fixed with 2 changes:
Let me know if you would like me to work on these, I'm not familiar with local dev yet but I can set it up. |
That would be great if you can. I am not too familiar with PWA. You should be able to do I think Vite PWA does a lot more than needed. Perhaps just creating a manifest is good enough. Thoughts? Let me know if you have a hard time getting local dev to work. If you are on a Mac (which is what I have) it should be ok. |
Manifest alone sounds good enough to me. I'll work on a duplicate PR with some CSS. |
I pushed some changes to remove vite pwa but keep manifest. I have never heard of safe-area-inset-bottom 😂 I'll wait to see what you cook up. |
Going to merge this and release since there are some bugs pending. |
Fixes #3688