Repository navigation
Conversation
bbe3ff7 to
420856a
Compare
|
@johnl-amd Thanks for creating this PR on behalf of Felix. Can you confirm you were able run and verify that this skill is useful by itself? |
Manual test on MI300X hardwareI did a manual test of this skill on real hardware. I used one MI300X GPU. The GPU The vendored copy is correctThe vendored copy agrees with the upstream folder at commit The skill names 79 The skill makes correct kernelsI installed the
Then I wrote a new kernel. I used only the instructions in this skill. The kernel The kernel compiled and ran. The maximum error is 0.0. The documented API operates The two review evals are correctI tested the technical statement in each eval. Eval 1 says that Eval 2 says that an explicit You must match the ROCm versionTo run a kernel, you must do 4 steps. These steps are not easy to find:
Step 4 is important. A torch build for ROCm 6.4 compiles the kernel correctly. But The skill gives the correct ROCm version in its header. But no text tells you that 3 items to think about
|
Adds
ROCm/FlyDSLas a federation source and vendorsflydsl-kernel-authoringfrom it, so the nightly import keeps the catalog copy in step with FlyDSL, which becomes its source of truth.This supersedes #266 and #269, which were closed pending FlyDSL #1305 and #1304. Both merged on Oct 18, so the upstream skill now carries its own skill card and evals, and
SKILL.mdhas been split intoreferences/. The earlier PRs pointed at a feature branch and a pre-split copy of the skill, so this is a regenerated declaration rather than a reopen. Original work is Felix Li's.Declared license is
Apache-2.0, matching FlyDSL'sLICENSEand the skill card.Draft until the two FlyDSL skills are reviewed together; #274 stacks on this one for
flydsl-kernel-trace-analysis.No walkthrough yet. The one on the old branch described the previous thin-entry-point design, where the catalog copy deferred to a local FlyDSL checkout, which is no longer how the skill works. Better written by someone who can run it on Instinct hardware.
The README catalog row is deliberately not here. Every row links to
blob/main/skills/<name>/SKILL.md, which 404s on the external-reference check until the skill is actually onmain. Same split as #248 then #255: the row follows in a separate PR once this merges.Testing
federate_skills.py --only flydsl-kernel-authoring: vendors at6245f9b.publish.shthencheck.sh: 0 errors, 12 skills, Cursor and Codex manifests up to date.federation.jsonhand-edited rather than regenerated, to avoid an unrelated reordering of the existing sources.