pytorch-finetuning, speech2speech: bump transformers 4.57.1 -> 5.10.1 - #781
Merged
Conversation
lucbruni-amd
requested review from
adamlam2-amd and
harkgill-amd
as code owners
August 20, 2026 20:34
transformers 5 removed save_safetensors from TrainingArguments (safetensors is now the only serialization format), so SFTConfig no longer accepts it and the training scripts raised TypeError. Removing the arg keeps the same behavior since safetensors saving is the default.
…heck transformers 5 raised the default max_shard_size (5GB -> 50GB), so the smoke model now saves as a single model.safetensors instead of sharded files with an index. Accept either layout in verify-full-finetuning-output.
adamlam2-amd
approved these changes
Aug 21, 2026
adamlam2-amd
left a comment
adamlam2-amd
left a comment
Collaborator
There was a problem hiding this comment.
as long as it passes CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches the transformers 5.10.1 pin already adopted in pytorch-rocm-llms (#659). Closes #270. Unpinning the remaining pinned examples can be explored as a follow-up.