orchestrai(!orc): put per-playbook ReportPortal links in the PR comment - #688
Closed
saman-amd wants to merge 1 commit into
Closed
orchestrai(!orc): put per-playbook ReportPortal links in the PR comment#688saman-amd wants to merge 1 commit into
saman-amd wants to merge 1 commit into
Conversation
verdict.py resolves the build's ReportPortal launch URL but only emitted it to $GITHUB_OUTPUT (which the !orc workflow never surfaced). Carry it in the uploaded test-results/summary.json (rp_launch_url), including on the no-build/no-verdict failure paths, and have report.py render a per-row "Results -> ReportPortal" link in the sticky PR comment — so every playbook/device is one click from its results, even when a run fails. Drops the inaccurate "links are in each job summary" footer.
Collaborator
Author
|
Superseded — surfacing the ReportPortal link in the job summary instead of the PR comment, per feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No easy way to reach ReportPortal from an
!orcrun. The sticky comment footer claimed "ReportPortal links are in each job summary", but the!orcjobs never write them — so the link was effectively unreachable, worst when a run fails.Fix
verdict.pycarries the build's RP launch URL in the uploadedtest-results/summary.json(rp_launch_url), including on the no-build / no-verdict failure paths.report.pyrenders a per-row Results → [ReportPortal] link in the sticky comment.One click from the PR, per playbook/device, even on failures.