unsloth: fail install-deps on pip error (Windows) - #685
Merged
Conversation
The Windows install-deps block ran two pip installs; if the first (unsloth from git) failed, the second masked it and the block exited 0, so the missing package only surfaced later as a confusing verify-imports 'No module named unsloth'. Stop on error and check $LASTEXITCODE after each install. Refs #675.
lucbruni-amd
requested review from
adamlam2-amd and
harkgill-amd
as code owners
August 10, 2026 15:17
A single pip command surfaces any install failure via its exit code, so a failed unsloth install is no longer masked by a later successful install. Keeps the block user-facing (no CI-only lines).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows
install-depsblock runs two pip installs. If the first (unsloth[amd] @ git+…) fails, the second (triton-windows) masks it and the block exits 0 — so a failed install surfaces later as a confusingverify-imports'No module named unsloth' (e.g. #675, #567) instead of a clear install-deps failure.Fix:
$ErrorActionPreference='Stop'+ explicit$LASTEXITCODEchecks after each pip so a pip failure fails the step.Refs #675.