Vllm playbook - #167
Merged
Merged
Conversation
danielholanda
left a comment
danielholanda
left a comment
Collaborator
There was a problem hiding this comment.
Added some initial comments
eddierichter-amd
marked this pull request as ready for review
March 28, 2026 22:11
adamlam2-amd
reviewed
Apr 7, 2026
adamlam2-amd
reviewed
Apr 7, 2026
adamlam2-amd
reviewed
Apr 7, 2026
adamlam2-amd
reviewed
Apr 7, 2026
adamlam2-amd
left a comment
adamlam2-amd
left a comment
Collaborator
There was a problem hiding this comment.
left a couple comments above
…rch install command
…metnation of how it works
eddierichter-amd
force-pushed
the
vllm-playbook
branch
from
April 10, 2026 03:10
26e2175 to
0b44f9c
Compare
Collaborator
Author
|
Hi @adamlam2-amd and @sreeram-11 thanks for the great comments! I just went through them. Please let me know anymore feedback you have and there are additional changes that I should make. |
adamlam2-amd
approved these changes
Apr 10, 2026
adamlam2-amd
left a comment
adamlam2-amd
left a comment
Collaborator
There was a problem hiding this comment.
we can merge it but this might require significant changing and monitoring of the versions of:
- vllm
- pytorch
- rocm
- model versions
- python
We also have to wait for rocm 7.13 and py3.13, at least for the halo box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.