Add custom GPU kernels playbook: Vector Addition and Matrix Multiplication kernels - #100
Conversation
adamlam2-amd
left a comment
There was a problem hiding this comment.
pretty good! just a couple of minor things.
Address these, and then should be okay to merge for QA to check.
danielholanda
left a comment
There was a problem hiding this comment.
Looks good. Please take a look at the recommended suggestions before merging
jammm
left a comment
There was a problem hiding this comment.
Looks good overall with some minor nits here and there. This should be running on Windows too. If you face any issues, report them in this PR so we can help you fix it.
Also, I suggest renaming the folders to have underscore instead of space, e.g., `Matrix_Multiplication" instead of "Matrix Multiplication".
Addressed |
ded28cf to
5940135
Compare
…add_one_kernel.hip
Edited Next steps section.
Addressed feedback- moved the dependencies section to platform.md file, included theory on wavefronts, reorganized content.
Adding tests
added tests - matmul
Edits to the tests
Added an image to highlight grids and threads.
There was a problem hiding this comment.
LGTM with a couple minor nitpicks. Good to merge overall!
Also take a look at my comment in https://github.com/amd/playbooks/pull/100/changes#r3043808230
Summary
Adds a new supplemental playbook that teaches users how to write, compile, and launch custom GPU kernels on AMD hardware using PyTorch's ROCm build. The playbook covers two end-to-end flows, a high-level JIT path and a low-level native C++ extension path, applied across two examples: vector addition and matrix multiplication.
File Structure
Playbook Structure