[prakriya] Add extra dhatu support - #245
Open
yajnadevam wants to merge 5 commits into
Open
Conversation
# Conflicts: # vidyut-prakriya/tests/integration/main.rs
Contributor
Author
|
Should we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243
Added ~970 dhatus (counting separately same dhatu in multiple gana) in extra-dhatus.tsv. These 970 dhatus occur in the vedas and various classical texts. The dictionary references and attestations for these are documented in extra-dhatu-specs.tsv. I have removed the non-Paninian vedic and some irregular forms from the test since its not in scope. Excluded roots are listed in extra-dhatu-cross-roots.tsv
An integration test has been added to test against these. Its an expensive test, so ignored by default.
A small number of roots have minor issues, but we don't have to fix it in this issue.