[prakriya] लेट् implementation based on लट् लिट् लुङ् stems - #242
Conversation
Baseline 31% with Refactor sārvadhātuka + 3.4.97 cleaner Panini citation, no coverage change Current 75%
|
Seems to produce parasmaipadi forms also for एध
|
|
Under leṬ Whitney §720: the strict dhātupāṭha pada distinction is relaxed; many dhātus take either pada in the RV. However, since we are not supporting non-Panini let forms, I will fix it |
|
Any chance this will be merged soon? |
Sorry about the delay. I've gist'd the diffs 110K+. Github displays this partially only. So please use a local markdown viewer (for eg. a chrome extension) to view the raw files (2 parts). I will look at the code diffs over the coming week. |
|
Looks correct. Sutras 3.4.97.v1 (paras i-lopa) and 3.4.93 (atm e→ai) — together roughly double the paradigm. The biggest driver overall is the LetStem Lun/Lit split backed by 3.4.113 / 3.4.117, which adds two entirely new stem paradigms. Summary table these are the sutra that create the new forms:
|
tbdasap
left a comment
There was a problem hiding this comment.
The rest of the Let changes look good to me.
| 3.2.178.4 DyAyateH saMprasAraRaM ca | ||
| 3.3.106.1 SradantarorupasargavadvfttiH | ||
| 3.3.125.1 KanerqaqarekekavakA vAcyAH | ||
| 3.4.94.v2 siBvikaraRayoge leTi qAwAnAm anityatvam dvitIyapuruzaikavacane vaktavyam |
There was a problem hiding this comment.
I am assuming these 3 "vartikkas" are in some specific texts.
Could you please put the links to the specific pages ?
| let j = p.next_not_empty(i)?; | ||
| let n = p.pratyaya(j)?; | ||
|
|
||
| // 7.3.70 (ghor lopo leṭi vā): "for ghu dhātus (dā, dhā), [the antya] is |
There was a problem hiding this comment.
This may not be the right place for a "7.3.*" karya. Currently, I am unable to suggest
the right "prakarana" file where this would be fit in a way that the tests pass.
I will mark a TODO for myself to move this snippet to the right file/location.
Fixes #239
Most Panini reachable लेट् forms are now supported:
Vedic archaic forms cannot be derived purely from Paninian rules. This would require a system of "vedic rules" and vidyut may not be the right platform for supporting all such forms.
Types of non-compliance are:
Bug due to
T::Nitfrom #236 is also resolvedBoth forms now derive correctly:
brū → vac fix: The vac-substitution (2.4.53) is gated on ārdhadhātuka context (ardhadhatuka::run_before_vikarana). Since leṬ is sārvadhātuka per 3.4.113, the gate's early-return fires for leṬ and 2.4.53 never runs. brū is preserved → bravāvahai.
han → ghn fix: The old T::Nit hack triggered 6.4.98. Replaced that with the real Pāṇinian path -> leṬ pratyayas are tagged Sarvadhātuka (3.4.117) + pit (3.4.94) early in samjna.rs.