[prakriya] let-lakara fixes phase1: Fix Bhvadi current implementation - #237
Conversation
|
macos-13 has hit end of life sep 15,2025 ... 8 months ago. Github actions seems to be stuck on it. Is it really necessary to support vidyut on it? @tbdasap |
|
@akprasad macos-13 times out ... can we merge without it |
|
@yajnadevam yeah, we can merge without it. |
Lets go ahead please |
|
@tbdasap can you take a look? if you're busy over the next few days, I'll look Wednesday. |
tbdasap
left a comment
There was a problem hiding this comment.
Perhaps put similar page references if applicable as appropriate in other changes ?
|
LGTM - The "terminology", like 1sg, 2du etc. feels different though but that also seems to be the style in the referred book. |
|
Please see the gist of differences in tinnanta output (9997). |
|
For phase I, I have targeted Bhvadi cases where the stem is correct. This is a small fix that will address the most common issues and fixes the existing implementation. A complete leT fix is a much larger task and I have created #239 to address it. |
feel free to also rewrite the PR title and parts of the description on merge |
Fixes #236
bhū + leṬ final paradigm — exact match to Macdonell §159:
BavAt/BavAtiBavAtaHBavAn/BavAntiBavAH/BavAsiBavATaHBavATaBavA/BavAniBavAva/BavAvaHBavAma/BavAmaHCode summary (vidyut-prakriya/src/tin_pratyaya.rs):
substitute).
Test edits: