-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented AMBER_HEADER and AMBER_FOOTER variables #682
base: staging
Are you sure you want to change the base?
Changes from all commits
fc9cbcc
5ebfcd5
9148887
36ec329
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -1,4 +1,4 @@ | ||||||||
#!/usr/bin/env bash | ||||||||
# Written in [Amber](https://amber-lang.com/) | ||||||||
# version: {{ version }} | ||||||||
# date: {{ date }} | ||||||||
# date: {{ date }} | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider adding newline in the end of the file
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i've outlined before why it has to be hardcoded, so adding a newline here would mean that there are two newlines in the output There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah yes. We could |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is pretty long and adds up to the length of the
translate
method. Would you consider extracting it to a new privategen_header
(or something similar) method?