Add basic conformance tests for IVMs, system symbols, and local symtabs. #96
Conversation
| (toplevel '#$ion_1_0' null '#$ion_1_1' null) | ||
| (produces null null)) |
There was a problem hiding this comment.
Are the nulls necessary? I.e. is it possible to have (produces /* nothing */)?
There was a problem hiding this comment.
It is possible to do that, but having some stub data there ensures that the IVM is the only thing skipped.
conformance/local_symtab.ion
Outdated
|
|
||
|
|
||
| // Basic symbol expansion | ||
| (ion_1_0 (toplevel $ion_symbol_table::{symbols:["a"]}) |
There was a problem hiding this comment.
Suggestion—we should make sure that (toplevel $3::{ $7: ["a"] } ) here would also produce the same thing.
There was a problem hiding this comment.
Good idea, will do.
conformance/system_symbols.ion
Outdated
|
|
||
| (ion_1_1 | ||
| (toplevel '#$10') | ||
| (produces $ion_literal)) |
There was a problem hiding this comment.
I don't recall seeing this in the spec. Can we put a "todo" here until the system module is defined?
There was a problem hiding this comment.
Though I got the address here wrong, I'll fix that.
I'd be shocked if there's any debate whether $ion_literal and $ion_encoding are included, do you think there will be debate over their specific addresses?
There was a problem hiding this comment.
I see that now.
Can you remind me what $ion_literal is for?
EDIT—I just did a search in the tip of the ion-11-specification branch of ion-docs, and $ion_literal is not mentioned anywhere other than in the System Symbol Table section of the What's New chapter.
There was a problem hiding this comment.
$ion_literal is how one treats as application data something looking like an encoding directive.
At top-level $ion_literal::$ion_encoding::() expands to $ion_encoding::() rather than being evaluated as a directive. This avoids holes in the data model by ensuring anything can be written at top level.
It's a gap in the spec, and I know some edge cases we need to iron out, so cut issue amazon-ion/ion-docs#322
Co-authored-by: Matthew Pope <[email protected]>
Description of changes:
I believe the only 1.1-specific impact here is the test asserting that $10 is
$ion_literal.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.