Adds tests cases for make_* system macros #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Nov 21, 2024
| (produces {foo:0} )) | ||
| (then "a symbol with unknown text" | ||
| (text "(:make_field $0 1)") | ||
| // Could be (produces {$0:1} ), but some implementations don't support $0 nicely. |
There was a problem hiding this comment.
This is saying "$0 support is often bad early in an implementation's development" right? If so, I agree.
There was a problem hiding this comment.
Yeah, and it's also exposing a weakness in IonElement—it doesn't have any support for $0, but we're using it in the conformance runner in ion-java because it's so much easier to work with than IonValue.
| "in text using qualified system macro address 7" | ||
| (text " (:$ion::7 1) ") | ||
| "in binary using system macro address 7" | ||
| (binary "EF 07 00 00 01 00") |
There was a problem hiding this comment.
Interesting, make_timestamp is the only system macro that requires a 2-byte arg encoding bitmap. I think this is probably ok since most of its value proposition comes from usage in TDL, but it is eye-catching.
tgregg
reviewed
Nov 21, 2024
tgregg
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#88
Description of changes:
Adds actual test cases for all of the
make_*system macros.Things to review:
make_timestampcorrect? (I think they are, but I need confirmation.)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.