Tunes the initial size of the EExpressionArgReader's expressions ArrayList. #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
64 performed slightly better and resulted in a lower allocation rate for my sample of real-world data. We can continue to tune this as we test with a wider variety of sample data, but smaller data generally will not suffer from a larger initial size here (within reason). Performance plateaued at 64 for my data.
Speed: 250 ms/op -> 248 ms/op (-<1%)
Allocation rate: 194 KB/op -> 189 KB/op (-2.6%)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.