Add windows build to Build & Test workflow. #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobarr-amzn
previously approved these changes
Jan 27, 2025
Previously this was required due to an issue with the version API and how it constructed the version at build time. Co-authored-by: Joshua Barr <[email protected]>
jobarr-amzn
approved these changes
Jan 27, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #358, #255
Description of changes:
This PR adds a windows target to our Build & Test workflow, and addresses a couple issues that got in the way of successful windows builds while testing for this PR.
Some more information about the issues that were fixed can be found in #358. The first issue was due to GCC/Clang allowing named initializers (which are now a C++20 feature, but supported in C99) in C++, while MSVC does not.
The second issue was a result of refactoring dependencies a while ago, which resulted in google test being imported into the build tree earlier than a key option (
gtest_force_shared_crt) to not be set until after google test was imported, resulting in it not taking effect, and causing a linking error. I've moved that setting up to the top-level CMakeLists.txt.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.