-
Notifications
You must be signed in to change notification settings - Fork 14
feature: add barrier instruction support #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1a437f4
feature: add circuit-level barrier compiler directive
rmshaffer 5636198
change: allow barrier in verbatim blocks, keep supportedOperations en…
rmshaffer b0b4e00
enforce exact test outputs
rmshaffer ea641f6
add test
rmshaffer 217207b
Merge branch 'main' into rmshaffer/barrier
rmshaffer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| # Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"). You | ||
| # may not use this file except in compliance with the License. A copy of | ||
| # the License is located at | ||
| # | ||
| # http://aws.amazon.com/apache2.0/ | ||
| # | ||
| # or in the "license" file accompanying this file. This file is | ||
| # distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
| # ANY KIND, either express or implied. See the License for the specific | ||
| # language governing permissions and limitations under the License. | ||
|
|
||
| """Tests for the ``barrier`` compiler directive.""" | ||
|
|
||
| import pytest | ||
|
|
||
| import autoqasm as aq | ||
| from autoqasm.instructions import barrier, cnot, h | ||
|
|
||
|
|
||
| def test_barrier_on_qubits() -> None: | ||
| @aq.main | ||
| def program(): | ||
| h(0) | ||
| barrier([0, 1]) | ||
| cnot(0, 1) | ||
|
|
||
| expected_ir = """OPENQASM 3.0; | ||
| qubit[2] __qubits__; | ||
| h __qubits__[0]; | ||
| barrier __qubits__[0], __qubits__[1]; | ||
| cnot __qubits__[0], __qubits__[1];""" | ||
| assert program.build().to_ir() == expected_ir | ||
|
|
||
|
|
||
| def test_barrier_single_qubit() -> None: | ||
| @aq.main | ||
| def program(): | ||
| h(0) | ||
| barrier(0) | ||
|
|
||
| expected_ir = """OPENQASM 3.0; | ||
| qubit[1] __qubits__; | ||
| h __qubits__[0]; | ||
| barrier __qubits__[0];""" | ||
| assert program.build().to_ir() == expected_ir | ||
|
|
||
|
|
||
| def test_barrier_all_qubits() -> None: | ||
| @aq.main | ||
| def program(): | ||
| h(0) | ||
| barrier() | ||
| cnot(0, 1) | ||
|
|
||
| expected_ir = """OPENQASM 3.0; | ||
| qubit[2] __qubits__; | ||
| h __qubits__[0]; | ||
| barrier; | ||
| cnot __qubits__[0], __qubits__[1];""" | ||
| assert program.build().to_ir() == expected_ir | ||
|
|
||
|
|
||
| def test_barrier_disallowed_inside_gate_definition() -> None: | ||
| """Barriers are compiler directives, not unitary gates, so they must not | ||
| appear inside ``@aq.gate`` bodies.""" | ||
|
|
||
| @aq.gate | ||
| def bad_gate(q: aq.Qubit): | ||
| barrier(q) | ||
|
|
||
| @aq.main | ||
| def program(): | ||
| bad_gate(0) | ||
|
|
||
| with pytest.raises(aq.errors.InvalidGateDefinition): | ||
| program.build() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Since _as_qubit_iterable
can return a list or a GlobalQubitRegister, the return type is correct but could be more precise with Iterable[...] | GlobalQubitRegister
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GlobalQubitRegisteris already aIterable[aq_types.QubitIdentifierType], and the caller should only care that what comes back is anIterable[aq_types.QubitIdentifierType]. I think the extra type hint would be redundant here.However in general it's confusing that
GlobalQubitRegisteris both anoqpy.Qubitand anIterableof qubits - leaking a bit of oqpy abstractions through here, will look for a way to clean this up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened #110 to clean up the qubit-related types.