feature: clean up user-visible build-error tracebacks#104
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 52 +2
Lines 2201 2279 +78
Branches 254 266 +12
=========================================
+ Hits 2201 2279 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laurencap
reviewed
May 4, 2026
| # ``__autograph_generated_file*.py`` scratch module in the OS tmp dir; | ||
| # those frames are noise as well. We deliberately keep ``oqpy`` frames | ||
| # since they can point at meaningful type errors. | ||
| _INTERNAL_PATH_MARKERS: tuple[str, ...] = ( |
Contributor
There was a problem hiding this comment.
I feel like this will be difficult to keep up-to-date over time. Do we have any other options? Could we include all of autoqasm and exclude specific subdirs we don't want to include?
Contributor
Author
There was a problem hiding this comment.
Yeah, I agree this feels fragile. Let me think about it some more.
Contributor
Author
There was a problem hiding this comment.
I changed this to use a flag __filter_from_traceback__ which can be set at the module-level or subpackage-level as a marker to exclude it from tracebacks.
laurencap
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Hides AutoQASM-internal and malt-internal frames from tracebacks surfaced by build errors, so users see lines that are relevant to the code they wrote, not the transpiler's internal call stack. Makes typical @aq.main / @aq.subroutine compile errors have significantly shorter tracebacks and therefore easier to read.
Testing done:
tox passes. Validated UX in some error cases manually.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.