fix: raise DiscretizationError when rydbergLocal params missing#1265
Open
peterkomar-aws wants to merge 1 commit into
Open
fix: raise DiscretizationError when rydbergLocal params missing#1265peterkomar-aws wants to merge 1 commit into
peterkomar-aws wants to merge 1 commit into
Conversation
The discretize() function on LocalDetuning previously silently fell through with no time resolution when rydbergLocal was unavailable from GetDevice, producing invalid output that failed downstream validation. Now raises DiscretizationError with a clear message.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 169 169
Lines 10963 10964 +1
Branches 1412 1413 +1
=========================================
+ Hits 10963 10964 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
krneta
approved these changes
Jun 2, 2026
Contributor
krneta
left a comment
krneta
left a comment
There was a problem hiding this comment.
Looks fine to me. Just wondering how you tested it. Were you able to test it end-to-end?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discretize() function on LocalDetuning previously silently fell through with no time resolution when rydbergLocal was unavailable from GetDevice, producing invalid output that failed downstream validation. Now raises DiscretizationError with a clear message.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.